bshah requested changes to this revision. bshah added a reviewer: bshah. bshah added inline comments. This revision now requires changes to proceed.
INLINE COMMENTS > test_fake_input.cpp:328 > + // without an authentication we shouldn't get the signals > + m_fakeInput->requestTouchDown(0,QPointF(1, 2)); > + QVERIFY(!touchDownSpy.wait(100)); In addition to what @graesslin said, one point about coding style, KWayland is part of KF5 which follows KDE Frameworks 5 Coding style guide <https://techbase.kde.org/Policies/Frameworks_Coding_Style> for its code. You seem to have used inconsistent coding style for code here and as well other places. Please go over all the code you have added and correct it. > fakeinput_interface.h:128-132 > + void touchDownRequested(quint32 id, const QPointF &pos); > + void touchMotionRequested(quint32 id, const QSizeF &delta); > + void touchUpRequested(quint32 id); > + void touchCancelRequested(); > + void touchFrameRequested(); Given this will be part of public API, please add the documentation for this methods like other pointer methods. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1672 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bdhruve, Plasma, bshah Cc: bshah, graesslin, plasma-devel, sebas
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
