> On March 14, 2016, 8:29 p.m., Marco Martin wrote: > > applets/comic/package/contents/ui/main.qml, line 31 > > <https://git.reviewboard.kde.org/r/127356/diff/2/?file=450027#file450027line31> > > > > you don't know how big can be the native size of the image, can be > > either way too small to be usable or too big. > > Anthony Fieroni wrote: > What is your advice? I think the size must be resonable to be seen.
perhaps as width Math.max(units.gridUnit*25, Math.min( centerLayout.comicData.image.nativeWidth * 0.6, units.gridUnit * 5)) and the height the same ratio to that as the native size ratio - Marco ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127356/#review93515 ----------------------------------------------------------- On March 14, 2016, 8 p.m., Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127356/ > ----------------------------------------------------------- > > (Updated March 14, 2016, 8 p.m.) > > > Review request for Plasma, Kai Uwe Broulik, David Edmundson, and Marco Martin. > > > Repository: kdeplasma-addons > > > Description > ------- > > 1. Correct highlighted tabs visablity > 2. Scale content on update comic > 3. Open/close fullview widget > 4. Added icon > 5. Resize content > > > Diffs > ----- > > applets/comic/comic.h 302f7b8 > applets/comic/comic.cpp 97ec6a1 > applets/comic/package/contents/ui/FullViewWidget.qml 5f5470d > applets/comic/package/contents/ui/main.qml 4cf1cae > > Diff: https://git.reviewboard.kde.org/r/127356/diff/ > > > Testing > ------- > > Resize cannot get to work as i want :) > Plasmoid.switchWidth: centerLayout.comicData.image.width * 0.6 > Plasmoid.switchHeight: centerLayout.comicData.image.height * 0.6 > 60% of current image, i don't understaind how this must be written to start > working :P > > > File Attachments > ---------------- > > Screenshot_20160312_214006.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/e1aa2742-fc08-4554-b00c-125fcc7c9bb8__Screenshot_20160312_214006.png > > > Thanks, > > Anthony Fieroni > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
