----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127356/#review93515 -----------------------------------------------------------
Fix it, then Ship it! good improvement, i still think the switch should be done on a "fixed" size rather than the native size of the image, since you don't have an assurance wether will be a size that makes sense (perhaps this value could be used if bound betweed two fixed gridunit based bounds) applets/comic/package/contents/ui/FullViewWidget.qml (line 36) <https://git.reviewboard.kde.org/r/127356/#comment63757> a function called open() shouldn't close. would be better adding another function called toggleVisibility() applets/comic/package/contents/ui/FullViewWidget.qml (line 39) <https://git.reviewboard.kde.org/r/127356/#comment63756> tabs? applets/comic/package/contents/ui/main.qml (line 31) <https://git.reviewboard.kde.org/r/127356/#comment63755> you don't know how big can be the native size of the image, can be either way too small to be usable or too big. - Marco Martin On March 14, 2016, 8 p.m., Anthony Fieroni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/127356/ > ----------------------------------------------------------- > > (Updated March 14, 2016, 8 p.m.) > > > Review request for Plasma, Kai Uwe Broulik, David Edmundson, and Marco Martin. > > > Repository: kdeplasma-addons > > > Description > ------- > > 1. Correct highlighted tabs visablity > 2. Scale content on update comic > 3. Open/close fullview widget > 4. Added icon > 5. Resize content > > > Diffs > ----- > > applets/comic/comic.h 302f7b8 > applets/comic/comic.cpp 97ec6a1 > applets/comic/package/contents/ui/FullViewWidget.qml 5f5470d > applets/comic/package/contents/ui/main.qml 4cf1cae > > Diff: https://git.reviewboard.kde.org/r/127356/diff/ > > > Testing > ------- > > Resize cannot get to work as i want :) > Plasmoid.switchWidth: centerLayout.comicData.image.width * 0.6 > Plasmoid.switchHeight: centerLayout.comicData.image.height * 0.6 > 60% of current image, i don't understaind how this must be written to start > working :P > > > File Attachments > ---------------- > > Screenshot_20160312_214006.png > > https://git.reviewboard.kde.org/media/uploaded/files/2016/03/12/e1aa2742-fc08-4554-b00c-125fcc7c9bb8__Screenshot_20160312_214006.png > > > Thanks, > > Anthony Fieroni > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
