----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126793/#review92661 -----------------------------------------------------------
Sorry for the massive delay. That's really messed up on our side. We have a feature freeze next wednesday, it would be great to get this all merged by then. I just had a few tiny comments, but I think we're all good to go. applets/mediaframe/package/contents/ui/ConfigPaths.qml (line 176) <https://git.reviewboard.kde.org/r/126793/#comment63164> if this is a config page you need to use QtQuickControls.Button not PlasmaComponents applets/mediaframe/package/contents/ui/main.qml (line 26) <https://git.reviewboard.kde.org/r/126793/#comment63161> whilst the video code is commented out, comment this out too. (or remove it) Otherwise we potentially have plasma failing to start if it's not installed for no benefit applets/mediaframe/package/contents/ui/main.qml (line 42) <https://git.reviewboard.kde.org/r/126793/#comment63166> why is this not loading from the config? applets/mediaframe/package/contents/ui/main.qml (line 135) <https://git.reviewboard.kde.org/r/126793/#comment63165> this isn't called by anyone. It's better to not leave future ideas lying about as they don't help the next person, just confuse them. - David Edmundson On Feb. 8, 2016, 11:34 a.m., Lars Pontoppidan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126793/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2016, 11:34 a.m.) > > > Review request for Plasma. > > > Repository: kdeplasma-addons > > > Description > ------- > > KF5 version of the (Picture) Frame widget > > > Diffs > ----- > > applets/CMakeLists.txt ed938f8 > applets/mediaframe/CMakeLists.txt PRE-CREATION > applets/mediaframe/Messages.sh PRE-CREATION > applets/mediaframe/package/contents/config/config.qml PRE-CREATION > applets/mediaframe/package/contents/config/main.xml PRE-CREATION > applets/mediaframe/package/contents/ui/ConfigGeneral.qml PRE-CREATION > applets/mediaframe/package/contents/ui/ConfigPaths.qml PRE-CREATION > applets/mediaframe/package/contents/ui/main.qml PRE-CREATION > applets/mediaframe/package/metadata.desktop PRE-CREATION > applets/mediaframe/plugin/mediaframe.h PRE-CREATION > applets/mediaframe/plugin/mediaframe.cpp PRE-CREATION > applets/mediaframe/plugin/mediaframeplugin.h PRE-CREATION > applets/mediaframe/plugin/mediaframeplugin.cpp PRE-CREATION > applets/mediaframe/plugin/qmldir PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/126793/diff/ > > > Testing > ------- > > kdeplasma-addons builds on Kubuntu 15.10. > > > Thanks, > > Lars Pontoppidan > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
