----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126373/ -----------------------------------------------------------
(Updated Jan. 5, 2016, noon) Status ------ This change has been marked as submitted. Review request for Plasma, Marco Martin and Uri Herrera. Changes ------- Submitted with commit 5af3ed10d98f4e65c4a056e99705b04d81d19ea7 by Marco Martin to branch master. Repository: plasma-framework Description ------- Problem ======= with the new taskbar we look that the look and feel is consistent between plasma and the applications therefore Uri change the selected application taskbar button to a blue background. The problem is that the blue background couldn't be the same blue than e.g. in the dolphin sidebar cause when you select an element in the sidebar the text color change from "black" to white which isn't possible in the system tray and than the contrast isn't that good in the panel for selected application (gray text on blue background). In addition the blue is very visible. see screenshot before. Solution ======== I like that we use the same color language but when you look at the dolphin toolbar on top selected elements (e.g. preview in the screenshot) are gray so I change the blue color for the selected application to gray and change minimized app to no border. what do you think? Diffs ----- src/desktoptheme/breeze/widgets/tasks.svgz 086558b Diff: https://git.reviewboard.kde.org/r/126373/diff/ Testing ------- I will test the new taskbar and hope someone else can test it too before we may ship it. File Attachments ---------------- taskbar style old https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/28f02c74-3489-4e35-a83f-45bd59a1e681__PlasmaThemeTaskbarBefore.png taskbar style new https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/1f9c7570-114d-4192-b2e5-0c713adfaad7__PlasmaThemeTaskbarAfter.png new tasks.svgz file move to /usr/share/plasma/desktoptheme/breeze/widgets/ https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/a6faa46d-1f81-4140-824c-983f6bb5671f__tasks.svgz taskbar old and new https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/fafdc5e8-bd92-43bd-8006-71088af6fdf4__taskbar.png tasks new blue boarder in difference to the original one https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/46755f5c-9c95-4e13-b5c6-4966496a5056__tasks.svgz new draft, origin, old draft https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/0851a433-b3f5-4d93-a7be-7540be0f0692__taskbar3.png Thanks, andreas kainz
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
