> On Dec. 20, 2015, 8:45 p.m., Eike Hein wrote: > > General PSA: I will soon push a fixed-up version of tasks.svgz to the repo > > that cleans up all the random margins and inconsistent corner styles in it > > that currently mess up alignments inside and outside of task buttons as > > well as corner appearance. Whatever the outcome of this, it needs to be > > rebased against those fixes first. > > Uri Herrera wrote: > The margins are not random. I literally had to use kruler and kmag to > properly align that. I even used a layered file with a red rectangle in it > because that area consists of a deadzone. I pointed that out when I made the > reveiw request originally. > > Eike Hein wrote: > The inside margins are currently inconsistent at the top and bottom > causing the icon to be vertically misaligned. The outside margins are > inconsistent as well - I think it's trying to position the button well inside > the panel, but this is an incorrect approach to the problem (the optical > imbalance with consistent margins is caused by how the panel inside margins > function, which is something we need to address in the theming system - my > approach to fix it was rejected, I'll be trying again though). The outside > margins and the corners (top ones rounded, bottom ones not) subtly break > things when the panel is anywhere but the bottom. > > I'm working on a series of changes to make the panel and Task Manager > finally pixel-perfect - fix the theme, fix the panel controller when > resizing, fix the panel default size, and fix something in FrameSVG/the panel > containment. > > Johan Ouwerkerk wrote: > In any case, the top version (new draft?) has markedly better alignment > of the text with icons... The other two versions seem vertically imbalanced > (more margin on the bottom than at the top). > Ideally, the icon is vertically aligned with the baseline of the text > such that ascenders and descenders extend equally far beyond the > corresponding border of the icon, hough this may be rather tricky when > considering languages with different baseline conventions (hanging or > variable or none). > > Eike Hein wrote: > The top version on the screenshot still shows all of the problems I'm > currently fixing FWIW. > > Eike Hein wrote: > I've now pushed the cleaned up tasks.svgz to git master. This fixes: > > * Fix inconsistent inside margins causing vertical misalignment inside > Task Buttons. > * Fix inconsistent outside margins causing incorrect alignment inside > panel. > * Fix outside margins and button corner appearance in locations other > than South. > * Align button frames with things like the pager edges. > * Fix a few instances of incorrect color scheme application. > * Remove many unused elements. > > This is what this gets us: http://i.imgur.com/7KaeJH5.png > > This took *hours* to fix. If anyone breaks these margins I will *eat* > them. Please base future changes on this version of the file! > > Johan Ouwerkerk wrote: > Much better! Appreciated. > > Perhaps a test application that sets window name in a variety of scripts > might be useful to check how it performs on various scripts...? > > Eike Hein wrote: > I test CJK and Arabic fairly regularly. > > andreas kainz wrote: > as I'm to jung to die can you change the behavior from your new > tasks.svgz file to > > 3. add blue boarder as all other tasks have (see first line in > taskbar3.png) > > as suggested above. > > Kai Uwe Broulik wrote: > Looking good, Eike, I'm just not sure about the gray background for > minimized tasks. It makes them more prominent than the non-minimized ones - I > liked the frameless variant for those better. > > andreas kainz wrote: > Eike can I have a blue boarder for the selected task as fare as I see > it's the only selection mode without border. > > Marco Martin wrote: > I added a tasks.svgz to the review request. > I did *not* change any margin or metric, but i made the look more > translucent with visible blue border > (also fixed the stylesheet that was broken in a way that continued to > work on plasma, but was completely broken in inkscape)
Martin, did you forget to add it? I got no email about it and rbt patch says the patch doesn't apply. - Eike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126373/#review89779 ----------------------------------------------------------- On Dec. 16, 2015, 7:23 p.m., andreas kainz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126373/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2015, 7:23 p.m.) > > > Review request for Plasma, Marco Martin and Uri Herrera. > > > Repository: plasma-framework > > > Description > ------- > > Problem > ======= > with the new taskbar we look that the look and feel is consistent between > plasma and the applications therefore Uri change the selected application > taskbar button to a blue background. The problem is that the blue background > couldn't be the same blue than e.g. in the dolphin sidebar cause when you > select an element in the sidebar the text color change from "black" to white > which isn't possible in the system tray and than the contrast isn't that good > in the panel for selected application (gray text on blue background). In > addition the blue is very visible. see screenshot before. > > Solution > ======== > I like that we use the same color language but when you look at the dolphin > toolbar on top selected elements (e.g. preview in the screenshot) are gray so > I change the blue color for the selected application to gray and change > minimized app to no border. > > what do you think? > > > Diffs > ----- > > src/desktoptheme/breeze/widgets/tasks.svgz 086558b > > Diff: https://git.reviewboard.kde.org/r/126373/diff/ > > > Testing > ------- > > I will test the new taskbar and hope someone else can test it too before we > may ship it. > > > File Attachments > ---------------- > > taskbar style old > > https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/28f02c74-3489-4e35-a83f-45bd59a1e681__PlasmaThemeTaskbarBefore.png > taskbar style new > > https://git.reviewboard.kde.org/media/uploaded/files/2015/12/15/1f9c7570-114d-4192-b2e5-0c713adfaad7__PlasmaThemeTaskbarAfter.png > new tasks.svgz file move to /usr/share/plasma/desktoptheme/breeze/widgets/ > > https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/a6faa46d-1f81-4140-824c-983f6bb5671f__tasks.svgz > taskbar old and new > > https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/fafdc5e8-bd92-43bd-8006-71088af6fdf4__taskbar.png > tasks new blue boarder in difference to the original one > > https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/46755f5c-9c95-4e13-b5c6-4966496a5056__tasks.svgz > new draft, origin, old draft > > https://git.reviewboard.kde.org/media/uploaded/files/2015/12/16/0851a433-b3f5-4d93-a7be-7540be0f0692__taskbar3.png > > > Thanks, > > andreas kainz > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
