----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/ -----------------------------------------------------------
(Updated Nov. 13, 2015, 9:27 a.m.) Review request for Plasma, Ashish Bansal and Bhushan Shah. Changes ------- Minor changes in syntax Repository: plasma-mediacenter Description ------- Implemented it like the other datasources. Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . handleLastFmNewMedia then calls fetchImage for each newMedia in the newMediaList Removed redundant imageFetched from LastFmImageFetcher gotImage calls the signal imageFetched in PmcImageCache which is again connected to signalUpdate in PmcMetaDataModel Diffs (updated) ----- autotests/CMakeLists.txt 04ba1c3 autotests/lastfmimagefetchertest.h eb7cb29 autotests/lastfmimagefetchertest.cpp abb3fd6 datasources/CMakeLists.txt a7171b7 datasources/lastfm/CMakeLists.txt PRE-CREATION datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION libs/mediacenter/CMakeLists.txt 5a13449 libs/mediacenter/lastfmimagefetcher.h ecff37e libs/mediacenter/lastfmimagefetcher.cpp e005077 libs/mediacenter/pmcimagecache.h 6399461 libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe Diff: https://git.reviewboard.kde.org/r/125993/diff/ Testing ------- Built and Tested. Thanks, Aditya Dev Sharma
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
