> On Nov. 13, 2015, 9:23 a.m., Ashish Bansal wrote: > > libs/mediacenter/lastfmimagefetcher.cpp, line 158 > > <https://git.reviewboard.kde.org/r/125993/diff/2-3/?file=416650#file416650line158> > > > > As imageFetcher is a signal, append "emit" word in the beginning. > > Although it is an empty macro, but it helps in understanding code better.
Sorry, I wanted to say imageFetched, not imageFetcher. - Ashish ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/#review88315 ----------------------------------------------------------- On Nov. 12, 2015, 7:21 p.m., Aditya Dev Sharma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125993/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2015, 7:21 p.m.) > > > Review request for Plasma, Ashish Bansal and Bhushan Shah. > > > Repository: plasma-mediacenter > > > Description > ------- > > Implemented it like the other datasources. > > Signal newMedia from MediaLibrary is absorbed by handleLastFmNewMedia . > handleLastFmNewMedia then calls fetchImage for each newMedia in the > newMediaList > > Removed redundant imageFetched from LastFmImageFetcher > gotImage calls the signal imageFetched in PmcImageCache which is again > connected to signalUpdate in PmcMetaDataModel > > > Diffs > ----- > > autotests/CMakeLists.txt 04ba1c3 > autotests/lastfmimagefetchertest.h eb7cb29 > autotests/lastfmimagefetchertest.cpp abb3fd6 > datasources/CMakeLists.txt a7171b7 > datasources/lastfm/CMakeLists.txt PRE-CREATION > datasources/lastfm/lastfmimagefetcher.desktop PRE-CREATION > libs/mediacenter/CMakeLists.txt 5a13449 > libs/mediacenter/lastfmimagefetcher.h ecff37e > libs/mediacenter/lastfmimagefetcher.cpp e005077 > libs/mediacenter/pmcimagecache.h 6399461 > libs/mediacenter/pmcmetadatamodel.cpp 2fe6efe > > Diff: https://git.reviewboard.kde.org/r/125993/diff/ > > > Testing > ------- > > Built and Tested. > > > Thanks, > > Aditya Dev Sharma > >
_______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
