----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119748/#review64426 -----------------------------------------------------------
applets/kickoff/package/contents/ui/KickoffButton.qml <https://git.reviewboard.kde.org/r/119748/#comment45017> anchors.margins sets all the margins. And if you're at it, can you migrate that to units.smallSpacing (or so), ie. no hardcoded pixels? applets/kickoff/package/contents/ui/KickoffButton.qml <https://git.reviewboard.kde.org/r/119748/#comment45018> Superfluous semicolon - Kai Uwe Broulik On Aug. 13, 2014, 12:37 vorm., Dan Vrátil wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119748/ > ----------------------------------------------------------- > > (Updated Aug. 13, 2014, 12:37 vorm.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > The icons and labels are misaligned (both vertically and horizontally) in > Kickoff (see the first screenshow) - this patch makes sure that the content > of the tab is always centered in both vertical and horizontal mode (see the > last screenshot). > > > Diffs > ----- > > applets/kickoff/package/contents/ui/KickoffButton.qml 3a55c46 > > Diff: https://git.reviewboard.kde.org/r/119748/diff/ > > > Testing > ------- > > Tested Kickoff in vertical and horizontal mode, all tab labels are correctly > centered > > > File Attachments > ---------------- > > Before > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/cc2752ee-9684-42e4-b146-d918351951f8__kickoff-before.png > After 2 > > https://git.reviewboard.kde.org/media/uploaded/files/2014/08/13/3676134b-051f-4d19-93b7-d699ffa91288__kickoff-after2.png > > > Thanks, > > Dan Vrátil > >
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
