----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119748/ -----------------------------------------------------------
(Updated Aug. 13, 2014, 2:01 a.m.) Review request for Plasma. Changes ------- Realized that previous version of the patch was breaking Kickoff in horizontal mode and found out that the problem is actually deeper than I thought. Summary (updated) ----------------- Properly align KickoffButtons to center Repository: plasma-desktop Description (updated) ------- The first and the last labels in Kickoff are misaligned (see the first screenshot) for some reason - even though the Label correctly fills the entire parent width, the test is still aligned to left. To workaround this issue, this patch wraps the Label into an Item - now the labels are correctly aligned in the center . I don't have any explanation for why does this happen, nor do I understand why wrapping the stuff in Item fixes the problem, so please don't ask (but please explain it to me if you happen to know) :-). Diffs (updated) ----- applets/kickoff/package/contents/ui/KickoffButton.qml 3a55c46 Diff: https://git.reviewboard.kde.org/r/119748/diff/ Testing (updated) ------- Tested Kickoff in vertical and horizontal mode, all tab labels are correctly centered File Attachments ---------------- Before https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/cc2752ee-9684-42e4-b146-d918351951f8__kickoff-before.png After https://git.reviewboard.kde.org/media/uploaded/files/2014/08/12/dd8b7151-2ab1-43de-acaf-b010d57e3efb__kickoff-after.png Thanks, Dan Vrátil
_______________________________________________ Plasma-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/plasma-devel
