ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> fonts.cpp:136
> + for (KXftConfig::Hint::Style s : {KXftConfig::Hint::None,
> KXftConfig::Hint::Slight, KXftConfig::Hint::Medium, KXftConfig::Hint::Full}) {
> + auto *item = new
> QStandardItem(KXftConfig::description((KXftConfig::Hint::Style)s));
> + m_hintingOptionsModel->appendRow(item);
This C cast is unnecessary. Also the * is merely redundant with auto (you can
keep it but it's not necessary).
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D27156
To: bport, #plasma, ervin, crossi, meven
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart