crossi added inline comments.
INLINE COMMENTS
> fonts.cpp:201
> + Q_ASSERT(dpiItem && dpiWaylandItem && antiAliasingItem);
> + if (dpiItem->isSaveNeeded() || dpiWaylandItem->isSaveNeeded() ||
> antiAliasingItem) {
> + emit aliasingChangeApplied();
antiAliasingItem->isSaveNeeded() ?
> fontssettingsaa.cpp:154
> +
> + KXftConfig::SubPixel::Type spType =
> (KXftConfig::SubPixel::Type)m_subPixel;
> + if (m_subPixelChanged || xft.subPixelTypeHasLocalConfig()) {
`static_cast<>` instead of c-style cast
Also, you can move closer the declaration of `spType`
> fontssettingsaa.cpp:161
> +
> + KXftConfig::Hint::Style hStyle = (KXftConfig::Hint::Style)m_hinting;
> + if (m_hintingChanged || xft.hintStyleHasLocalConfig()) {
`static_cast<>` instead of c-style cast
Also, you can move closer the declaration of `hStyle`
> krdb.cpp:774
>
> - QString hintStyle = generalCfgGroup.readEntry("XftHintStyle",
> "hintslight");
> + KXftConfig::Hint::Style hStyle =
> (KXftConfig::Hint::Style)settingsAA.hinting();
> + QString hintStyle = KXftConfig::toStr(hStyle);
`static_cast<>`
> krdb.cpp:788
>
> - QString subPixel = generalCfgGroup.readEntry("XftSubPixel", "rgb");
> + KXftConfig::SubPixel::Type spType =
> (KXftConfig::SubPixel::Type)settingsAA.subPixel();
> + QString subPixel = KXftConfig::toStr(spType);
`static_cast<>`
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D27156
To: bport, #plasma, ervin, crossi, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
