gvgeo marked 3 inline comments as done.
gvgeo added a comment.
I marked 3 comments as done that had forgotten, as I removed the old tooltip
code.
If there is something else, please be more specific. I can not see a better
way to address any of your comments.
INLINE COMMENTS
> BatteryItem.qml:64
>
> - states: [
> - State {
> - when: !!detailsLayout.parent.inListView // HACK
> - PropertyChanges {
> - target: detailsLabel
> - horizontalAlignment: modelData.value ?
> Text.AlignRight : Text.AlignLeft
> - font.pointSize: theme.smallestFont.pointSize
> - width: parent ? parent.width / 2 : 0
> - elide: Text.ElideNone // eliding and height:
> implicitHeight causes loops
> - }
> + onPaintedWidthChanged: { // horrible HACK to get a column
> layout
> + if (modelData.label && paintedWidth >
> detailsLayout.leftColumnWidth) {
No, it does not. Those two comments were in the same commit, to avoid the
GridLayout crash.
https://phabricator.kde.org/R120:d12521b149fa7766fbbeb9957bde14b4a6278928
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26806
To: gvgeo, #plasma, #vdg, davidedmundson
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage,
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen,
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts,
sebas, apol, ahiemstra, mart
