davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
Few of my initial comments do not seem to be addressed yet.
INLINE COMMENTS
> BatteryItem.qml:64
>
> - states: [
> - State {
> - when: !!detailsLayout.parent.inListView // HACK
> - PropertyChanges {
> - target: detailsLabel
> - horizontalAlignment: modelData.value ?
> Text.AlignRight : Text.AlignLeft
> - font.pointSize: theme.smallestFont.pointSize
> - width: parent ? parent.width / 2 : 0
> - elide: Text.ElideNone // eliding and height:
> implicitHeight causes loops
> - }
> + onPaintedWidthChanged: { // horrible HACK to get a column
> layout
> + if (modelData.label && paintedWidth >
> detailsLayout.leftColumnWidth) {
You can't do that.
That'll change the column size, which will change our text bounding box which
will change our paintedWidth. A loop.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26806
To: gvgeo, #plasma, #vdg, davidedmundson
Cc: ngraham, manueljlin, davidedmundson, plasma-devel, Orage, LeGast00n,
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
apol, ahiemstra, mart
