ngraham added inline comments.
INLINE COMMENTS
> ConfigGeneral.qml:23
> +import QtQuick 2.5
> +import QtQuick.Controls 1.4 as QQC1
> +import QtQuick.Controls 2.5 as QQC2
there are no longer any QQC1 items here; you can remove this import entirely
> ConfigGeneral.qml:65
> + Layout.fillWidth: true
> + Layout.fillHeight: true
> +
These have no effect because the ListView isn't in a layout; you can just
remove them
> ConfigGeneral.qml:86
>
> - Item {
> - Kirigami.FormData.isSection: true
> - Kirigami.FormData.label: i18n("Categories")
> - }
> + QIconItem {
> + id: theIcon
Use a `Kirigami.Icon` instead as it has better scaling behavior
> ConfigGeneral.qml:101
> + enabled: !showAllCheckBox.checked
> + model: isPlasmoid ? [i18n("Auto"), i18n("Shown"),
> i18n("Hidden"), i18n("Disabled")] : [i18n("Auto"), i18n("Shown"),
> i18n("Hidden")]
> +
Might be cleaner to set up the combobox model like so:
https://cgit.kde.org/kdeplasma-addons.git/tree/wallpapers/potd/contents/ui/config.qml#n82,
and then you could simplify `currentIndex` and `onActivated` a lot
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D22176
To: nicolasfella, #plasma, #vdg
Cc: kmaterka, filipf, broulik, ngraham, plasma-devel, LeGast00n,
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
apol, ahiemstra, mart
