ngraham added inline comments.
INLINE COMMENTS
> ConfigGeneral.qml:101
> + enabled: !showAllCheckBox.checked
> + model: isPlasmoid ? [i18n("Auto"), i18n("Shown"),
> i18n("Hidden"), i18n("Disabled")] : [i18n("Auto"), i18n("Shown"),
> i18n("Hidden")]
> +
While we're at it, I might suggest using visibility strings that are bit more
obvious about their purpose. In particular "Auto" has the same issue as "Smart"
in that it's not clear what it actually does. I might propose something like
this:
Always shown
Shown while in use/when relevant/something like that
Only shown in pop-up
Disabled
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D22176
To: nicolasfella, #plasma, #vdg
Cc: kmaterka, filipf, broulik, ngraham, plasma-devel, LeGast00n,
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,
apol, ahiemstra, mart
