ivan requested changes to this revision.
ivan added a comment.
This revision now requires changes to proceed.
@davidedmundson
Yes, the wrapper just serves for keyval iterators to be usable with a
range-based for loop. Quite useful if there are a lot of these. In this case,
where it is only one loop I agree it might be an overkill.
@meven
Just a single nit-pick left :)
INLINE COMMENTS
> fetchsqlite.cpp:101
> + for (auto entry = bindObjects.constKeyValueBegin(); entry !=
> bindObjects.constKeyValueEnd(); ++entry) {
> + query.bindValue((*entry).first, (*entry).second);
> //qDebug() << "* Bound " << variableName << " to " <<
> query.boundValue(variableName);
`entry->first` and `entry->second`
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D26438
To: meven, #plasma, davidedmundson, ivan
Cc: ivan, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
