davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Cool, thanks
INLINE COMMENTS
> fetchsqlite.cpp:100
> query.prepare(sql);
> - foreach(const QString &variableName, bindObjects.keys()) {
> + for(const QString &variableName : bindObjects.keys()) {
> query.bindValue(variableName, bindObjects.value(variableName));
There's an optimisation available here
> windowsrunner.cpp:78
>
> - foreach (const WId w, KWindowSystem::windows()) {
> + for (const WId w : KWindowSystem::windows()) {
> KWindowInfo info(w, NET::WMWindowType | NET::WMDesktop |
Does this detach?
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D26438
To: meven, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
