2010/8/4, Lucas Nussbaum <[email protected]>: > Hi, > > Quick review: > - use english for commit messages :-) > - changelog: UNRELEASED -> unstable > - you should have a libglobalhotkeys-ruby1.8 that contains the actual > files, as well as a libglobalhotkeys-ruby package that simply depends > on libglobalhotkeys-ruby (see the other packages in the repo) > - no '.' at end of Description's first line. > - use sentences in long description. > - in rules, use the cdbs classes provided by the team, not the default > debhelper template (see other packages) > - your library is loaded using require 'rghk', so I think that it makes > more sense to name the package librghk-ruby. > >> I still have two lintian infos : >> description-synopsis-might-not-be-phrased-properly >> possible-documentation-but-no-doc-base-registration >> >> Do you think I should rephrase the description or use doc-base ? > > Yes, probably both. > -- > | Lucas Nussbaum > | [email protected] http://www.lucas-nussbaum.net/ | > | jabber: [email protected] GPG: 1024D/023B3F4F | >
Hi Lucas. Thanks for your review. I will take a look at cdbs and doc-base which I do not know. I will let you know when I have done taking acount of your remarks. Sorry for the french commit message :(. I had to be sleepy when I made it. Vincent Carmona _______________________________________________ Pkg-ruby-extras-maintainers mailing list [email protected] http://lists.alioth.debian.org/mailman/listinfo/pkg-ruby-extras-maintainers
