control: tag -1 patch

On Sat, Apr 5, 2014 at 5:22 PM, Michael Gilbert wrote:
> It probably makes sense to change the default to 5 rather than 25.

Hi,

I've attached a proposed patch that makes this change.  Please review.

Best wishes,
Mike
diff -Nru pulseaudio-5.0/debian/changelog pulseaudio-5.0/debian/changelog
--- pulseaudio-5.0/debian/changelog	2014-03-28 23:21:13.000000000 +0000
+++ pulseaudio-5.0/debian/changelog	2014-04-05 21:34:41.000000000 +0000
@@ -1,3 +1,10 @@
+pulseaudio (5.0-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Set default-fragment-size-msec to 5 milliseconds (closes: #581624). 
+
+ -- Michael Gilbert <[email protected]>  Sat, 05 Apr 2014 21:33:06 +0000
+
 pulseaudio (5.0-1) unstable; urgency=medium
 
   [ Balint Reczey ]
diff -Nru pulseaudio-5.0/debian/patches/0004-fragment-size.patch pulseaudio-5.0/debian/patches/0004-fragment-size.patch
--- pulseaudio-5.0/debian/patches/0004-fragment-size.patch	1970-01-01 00:00:00.000000000 +0000
+++ pulseaudio-5.0/debian/patches/0004-fragment-size.patch	2014-04-05 22:06:48.000000000 +0000
@@ -0,0 +1,50 @@
+Description: the default fragment size of 25 milliseconds is too large, which leads to buffer overruns and audio stuttering
+Author: Michael Gilbert <[email protected]>
+Bug-Debian: http://bugs.debian.org/581624
+
+--- a/src/daemon/daemon-conf.c
++++ b/src/daemon/daemon-conf.c
+@@ -96,7 +96,7 @@ static const pa_daemon_conf default_conf
+     .lock_memory = false,
+     .deferred_volume = true,
+     .default_n_fragments = 4,
+-    .default_fragment_size_msec = 25,
++    .default_fragment_size_msec = 5,
+     .deferred_volume_safety_margin_usec = 8000,
+     .deferred_volume_extra_delay_usec = 0,
+     .default_sample_spec = { .format = PA_SAMPLE_S16NE, .rate = 44100, .channels = 2 },
+--- a/src/daemon/daemon.conf.in
++++ b/src/daemon/daemon.conf.in
+@@ -87,7 +87,7 @@ ifelse(@HAVE_SYS_RESOURCE_H@, 1, [dnl
+ ; default-channel-map = front-left,front-right
+ 
+ ; default-fragments = 4
+-; default-fragment-size-msec = 25
++; default-fragment-size-msec = 5
+ 
+ ; enable-deferred-volume = yes
+ ; deferred-volume-safety-margin-usec = 8000
+--- a/src/pulsecore/core.c
++++ b/src/pulsecore/core.c
+@@ -111,7 +111,7 @@ pa_core* pa_core_new(pa_mainloop_api *m,
+     c->default_sample_spec.channels = 2;
+     pa_channel_map_init_extend(&c->default_channel_map, c->default_sample_spec.channels, PA_CHANNEL_MAP_DEFAULT);
+     c->default_n_fragments = 4;
+-    c->default_fragment_size_msec = 25;
++    c->default_fragment_size_msec = 5;
+ 
+     c->deferred_volume_safety_margin_usec = 8000;
+     c->deferred_volume_extra_delay_usec = 0;
+--- a/man/pulse-daemon.conf.5.xml.in
++++ b/man/pulse-daemon.conf.5.xml.in
+@@ -465,8 +465,8 @@ USA.
+     </option>
+     <option>
+       <p><opt>default-fragment-size-msec=</opt>The duration of a
+-      single fragment. Defaults to 25ms (i.e. the total buffer is thus
+-      100ms long).</p>
++      single fragment. Defaults to 5ms (i.e. the total buffer is thus
++      20ms long).</p>
+     </option>
+ 
+   </section>
diff -Nru pulseaudio-5.0/debian/patches/series pulseaudio-5.0/debian/patches/series
--- pulseaudio-5.0/debian/patches/series	2014-03-28 23:21:13.000000000 +0000
+++ pulseaudio-5.0/debian/patches/series	2014-04-05 22:05:24.000000000 +0000
@@ -2,3 +2,4 @@
 0002-Use-the-fixed-point-speex-resampler-on-ARM.patch
 0003-exit-with-X-session.patch
 kfreebsd_no_lock_and_threads_synchro.patch
+0004-fragment-size.patch
_______________________________________________
pkg-pulseaudio-devel mailing list
[email protected]
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-pulseaudio-devel

Reply via email to