Hi, On 03/01/2013 06:08 PM, Benjamin Drung wrote: >>> > > DEB_HOST_ARCH >>> > > DEB_HOST_ARCH_CPU >>> > > >>> > > on powerpc and powerpcspe? >> > >> > On powerpcspe, we have the following settings: >> > >> > DEB_HOST_ARCH=powerpc >> > DEB_HOST_ARCH_CPU=powerpcspe > Isn't it the other way around?
Of course, sorry! >> > The two filters on the patch are just used to detect the case of powerpc >> > in general, but excluding the powerpcspe case (a special case of >> > powerpc). Resulting in "powerpc-" for the case with altivec. In all >> > other cases (including powerpcspe and non-powerpc), we disable altivec. > What do you think about the alternative attached patch? > diff --git a/debian/rules b/debian/rules > index 4d3c5dc..3203434 100755 > --- a/debian/rules > +++ b/debian/rules > @@ -193,14 +193,19 @@ confflags += --disable-neon > removeplugins += neon > endif > > -# PowerPC specific optimizations > -ifneq ($(filter $(DEB_HOST_ARCH_CPU),powerpc),) > +# PowerPC specific optimizations (excluding powerpcspe) > +ifeq (,$(filter-out powerpc,$(DEB_HOST_ARCH_CPU))$(filter > powerpcspe,$(DEB_HOST_ARCH))) > confflags += --enable-altivec > else > confflags += --disable-altivec > removeplugins += altivec > endif Effect should be equivalent to my proposal. > > +# PowerPCSPE specific optimizations > +ifeq (,$(filter-out powerpcspe,$(DEB_HOST_ARCH)) This line looks more complicated to me than my original proposal, but should be equivalent for our purposes. Finally, maybe a matter of taste. So this patch would be fine for powerpcspe, also Thanks, Roland _______________________________________________ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
