Am Freitag, den 01.03.2013, 16:05 +0100 schrieb Roland Stigge: > Hi, > > On 03/01/2013 03:43 PM, Benjamin Drung wrote: > > Am Mittwoch, den 27.02.2013, 18:47 +0100 schrieb Roland Stigge: > >> As you can see above, -mtune=G4 is used by default, leading to the above > >> illegal instructions. The attached patch fixes this by enabling altivec > >> only on > >> powerpc _except_ powerpcspe, and doing "confflags += --with-tuning=8548" > >> which > >> is propagated to gcc as "-mtune=8548" on powerpcspe. > > > > Your patch logic looks complicated (multiple filters). What are the > > values of > > > > DEB_HOST_ARCH > > DEB_HOST_ARCH_CPU > > > > on powerpc and powerpcspe? > > On powerpcspe, we have the following settings: > > DEB_HOST_ARCH=powerpc > DEB_HOST_ARCH_CPU=powerpcspe
Isn't it the other way around? > The two filters on the patch are just used to detect the case of powerpc > in general, but excluding the powerpcspe case (a special case of > powerpc). Resulting in "powerpc-" for the case with altivec. In all > other cases (including powerpcspe and non-powerpc), we disable altivec. What do you think about the alternative attached patch? -- Benjamin Drung Debian & Ubuntu Developer
diff --git a/debian/rules b/debian/rules index 4d3c5dc..3203434 100755 --- a/debian/rules +++ b/debian/rules @@ -193,14 +193,19 @@ confflags += --disable-neon removeplugins += neon endif -# PowerPC specific optimizations -ifneq ($(filter $(DEB_HOST_ARCH_CPU),powerpc),) +# PowerPC specific optimizations (excluding powerpcspe) +ifeq (,$(filter-out powerpc,$(DEB_HOST_ARCH_CPU))$(filter powerpcspe,$(DEB_HOST_ARCH))) confflags += --enable-altivec else confflags += --disable-altivec removeplugins += altivec endif +# PowerPCSPE specific optimizations +ifeq (,$(filter-out powerpcspe,$(DEB_HOST_ARCH)) +confflags += --with-tuning=8548 +endif + %: dh $@ --parallel --with autoreconf
_______________________________________________ pkg-multimedia-maintainers mailing list pkg-multimedia-maintainers@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers
