Control: reassign -1 libgmtk1 1.0.7-1
Control: retitle -1 gmtk: silently fails to take screenshots
Control: tags -1 + upstream fixed-upstream patch

The code to take the screenshots is in gtmk, hence I'm reassigning it to
gmtk. The patch to display an error message if mplayer failed to take a
screenshot is attached. This patch has been applied upstream.

On 2013-02-01 19:25:03, Francesco Poli wrote:
> > > I've installed mplayer (instead of mplayer2) to
> > > check if that might be a problem and in fact it is. With mplayer I can
> > > see the same error message in the log.
> 
> Woah!  I hadn't noticed the mplayer2 package in Debian!
> Shame on me: I see that it's in testing since 2011...
> 
> Is it mature enough to replace mplayer?

I haven't had any problems with it so far.

> > My analysis is wrong. It also depends on the video output used. In any
> > case, an error message would be appropriate.
> 
> In this case, maybe my mplayer configuration can help to pinpoint the
> issue:
> 
>   $ cat ~/.mplayer/config 
>   [default]
>   ao=jack,alsa
>   volume=20 
>   vo=xv

There is some special casing based on the selected vo, but the vo
selected in ~/.mplayer/config is ignored in gnome-mplayer. So there are
some things left I want you to try: explicitly select the vo in
gnome-mplayer's preferences, try to take a screenshot with both mplayer
and mplayer2 and maybe also try another vo.

I'm not familiar enough with all the quirks of the different video
outputs, so I need to rely on upstream's understanding of them.

Regards
-- 
Sebastian Ramacher
From fa33ed02e8d9330318779e5000d7473a1356ea68 Mon Sep 17 00:00:00 2001
From: kdekorte <kdekorte@cc285a5d-864f-f498-13c1-83eaf8612931>
Date: Sat, 2 Feb 2013 23:15:51 +0000
Subject: [PATCH 1/2] Add message when screenshot capture fails

git-svn-id: http://gmtk.googlecode.com/svn/trunk@203 cc285a5d-864f-f498-13c1-83eaf8612931
---
 ChangeLog               |    1 +
 src/gmtk_media_player.c |    8 ++++++++
 2 files changed, 9 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index 402a5eb..097f18b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,4 +1,5 @@
 Development
+	Add message when screenshot capture fails
 	Switch to GLIB for GMLIB header files, since GTK is not included
 	Switch to GTK VERSION tags when possible
 	Updated Japanese translation
diff --git a/src/gmtk_media_player.c b/src/gmtk_media_player.c
index b177a3f..b7055c6 100644
--- a/src/gmtk_media_player.c
+++ b/src/gmtk_media_player.c
@@ -3625,6 +3625,14 @@ gboolean thread_reader(GIOChannel * source, GIOCondition condition, gpointer dat
             message = NULL;
         }
 
+        if (strstr(mplayer_output->str, "failed (forgot -vf screenshot?)") != 0) {
+            dialog = gtk_message_dialog_new(NULL, GTK_DIALOG_DESTROY_WITH_PARENT, GTK_MESSAGE_ERROR,
+                                            GTK_BUTTONS_OK, g_dgettext(GETTEXT_PACKAGE, "Failed to take screenshot"));
+            gtk_window_set_title(GTK_WINDOW(dialog), g_dgettext(GETTEXT_PACKAGE, "GNOME MPlayer Notification"));
+            gtk_dialog_run(GTK_DIALOG(dialog));
+            gtk_widget_destroy(dialog);
+        }
+
         if (strstr(mplayer_output->str, "Name   : ") != 0) {
             buf = strstr(mplayer_output->str, "Name   : ");
             buf = strstr(mplayer_output->str, "Name   : ") + strlen("Name   : ");
-- 
1.7.10.4

Attachment: signature.asc
Description: Digital signature

_______________________________________________
pkg-multimedia-maintainers mailing list
pkg-multimedia-maintainers@lists.alioth.debian.org
http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-multimedia-maintainers

Reply via email to