----- Original Message ----
> From: "Martin Stjernholm, Roxen IS @ Pike developers forum"
><10...@lyskom.lysator.liu.se>
> To: pike-devel@lists.lysator.liu.se
> Sent: Sun, September 11, 2011 12:45:02 PM
> Subject: Re: Val.true and Val.false [Was: XMLRPC] (from p...@roxen.com)
>
> Thanks for the effort, but it still needs some fixing:
>
> The compat flag is the wrong way. The point with compat is that old
> code should continue to work without changes. With this patch it's
> still necessary to change some calls to get the old behavior back. (If
> you don't like the flag in new code then we could discuss controlling
> it with the pike compat level instead. It's a bit more cumbersome
> while migrating, but maybe less so later on.)
>
> Afaik xmlrpc <struct>s and <array>s are fully recursive. It doesn't
> look like the magic_false replacement code handles that.
>
> Shouldn't decode_call take the flag as well?
>
> Still missing a corresponding checkin in 7.9, but it'll come when the
> dust has settled?
>
Actually, I don't think it is necessary that decode_call take the flag, because
if you don't pass in any Val objects, then everything will be an int anyway.
It
currently isn't possible to encode boolean unless you use Val, so if you need
to, you will need to use the new features.
I'm creating a recursive function to handle replacing magic_false.
I reversed the flag, called it boolean instead.
I tried to commit 7.9, but it is giving me an error:
Counting objects: 172913, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (38656/38656), done.
Writing objects: 100% (170600/170600), 25.22 MiB | 104 KiB/s, done.
Total 170600 (delta 134386), reused 164359 (delta 129690)
remote: Commit 65a4850d0c0afba9b89ba4698b728c5224c3ee97 does not contain
d0344c6c82231970df581550111574da60aa8a84 in its first-parent ancestry.
remote: Did you pull with merge instead of rebase?
To git-p...@pike-git.lysator.liu.se:pike.git
! [remote rejected] 7.9 -> 7.9 (pre-receive hook declined)
error: failed to push some refs to 'git-p...@pike-git.lysator.liu.se:pike.git'
