----- Original Message ----
> From: "Martin Stjernholm, Roxen IS @ Pike  developers forum" 
><10...@lyskom.lysator.liu.se>
> To: pike-devel@lists.lysator.liu.se
> Sent: Sun, September 11, 2011 12:45:02 PM
> Subject: Re: Val.true and Val.false [Was: XMLRPC] (from p...@roxen.com)
> 
> Thanks for the effort, but it still needs some fixing:
> 
> The compat flag is  the wrong way. The point with compat is that old
> code should continue to work  without changes. With this patch it's
> still necessary to change some calls to  get the old behavior back. (If
> you don't like the flag in new code then we  could discuss controlling
> it with the pike compat level instead. It's a bit  more cumbersome
> while migrating, but maybe less so later on.)
> 
> Afaik  xmlrpc <struct>s and <array>s are fully recursive. It  doesn't
> look like the magic_false replacement code handles  that.
> 
> Shouldn't decode_call take the flag as well?
> 
> Still missing a  corresponding checkin in 7.9, but it'll come when the
> dust has settled?
>

Sure, actually, though, I did 7.9, but it looks like I just forgot to push it.

I will make those changes, so the compat is reversed.
  • Re:... Lance Dillon
    • ... Martin Stjernholm, Roxen IS @ Pike developers forum
      • ... Lance Dillon
        • ... Martin Stjernholm, Roxen IS @ Pike developers forum
          • ... Lance Dillon
            • ... Martin Stjernholm, Roxen IS @ Pike developers forum
              • ... Lance Dillon
              • ... Lance Dillon
                • ... Marcus Comstedt (ACROSS) (Hail Ilpalazzo!) @ Pike (-) developers forum
                • ... Martin Stjernholm, Roxen IS @ Pike developers forum
                • ... Lance Dillon
                • ... Lance Dillon
                • ... Martin Stjernholm, Roxen IS @ Pike developers forum
                • ... Martin Stjernholm, Roxen IS @ Pike developers forum
                • ... Lance Dillon
                • ... Martin Stjernholm, Roxen IS @ Pike developers forum
                • ... Lance Dillon

Reply via email to