> On Dec 19, 2014, at 21:14, kilon alios <kilon.al...@gmail.com> wrote: > > "Lines 4 to 11 are not necessary. Just remove them" > > thats great it removed one big thing that annoyed me. Why is this not > necessary ?
It’s essentially the old way of doing what the following lines of code in your method do. > "Lines 20 to 26 introduce 7 methods that are not needed, you could include > this in initializeWidgets itself. So we go from 36 to 29 methods at instance > side." > > why would I want to do that ? it will increase the method by 20 lines of code > and would look much meshier . I am not in a desperate need to decrease the > amount of methods so I can make other methods bigger and messier. > > "Lines 7 through 12 introduce 6 methods that are not needed, you could > include this in initialize itself. So we go from 29 to 23 methods at instance > side." > > again I will pass, I rather brake down things down to small method than > having one long method. > > "10 methods for a UI class is not so bad, is it?" > > I will say its worse because what we have now is a code that is as verbose > with less method but now harder to read as well because of very big methods > for Smalltalk standards. OK but then you should not complain about the fact that you have too many methods in your code. I gave you these suggestions because that seemed to be the main issue you were having. > One thing that interests me is , can avoid having to return the model by > separate methods and instead pass them to a dictionary/list/array and return > from only one method ? If yes that would be the turning point for me towards > Spec. I’m sorry but I do not understand your question. I would need a code example to better understand what you want. ---> Save our in-boxes! http://emailcharter.org <--- Johan Fabry - http://pleiad.cl/~jfabry PLEIAD lab - Computer Science Department (DCC) - University of Chile
