Two minor gripes about these new functions:

(1) I think pg_total_relation_size() is a bit more concise and clear than pg_complete_relation_size().

(2) pg_cancel_backend(), pg_reload_conf(), and pg_rotate_logfile() all return an int indicating success (1) or failure (0). Why shouldn't these functions return a boolean?

(Presumably there is a good reason why these functions return a status code at all, rather than aborting via elog on error -- right?)

-Neil

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
      choose an index scan if your joining column's datatypes do not
      match

Reply via email to