On 2017-02-07 16:36:55 -0500, Robert Haas wrote: > On Tue, Feb 7, 2017 at 4:15 PM, Andres Freund <and...@anarazel.de> wrote: > > FWIW, I think it'd have been better to not add the new callbacks as > > parameters to *_create(), but rather have them be "templatized" like the > > rest of simplehash. That'd require that callback to check the context, > > to know whether it should use shared memory or not, but that seems fine > > to me. Right now this pushes the head of simplehash above a > > cacheline... > > Something like the attached?
Yes. > +#ifndef SH_USE_NONDEFAULT_ALLOCATOR > + That should probably be documented in the file header. Thanks! Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
