On 11/01/17 22:30, Peter Eisentraut wrote: > On 1/11/17 3:35 PM, Petr Jelinek wrote: >> On 11/01/17 18:32, Peter Eisentraut wrote: >>> On 1/11/17 3:29 AM, Petr Jelinek wrote: >>>> Okay, looking into my notes, I originally did this because we did not >>>> allow adding tables without pkeys to publications which effectively >>>> prohibited FOR ALL TABLES publication from working because of >>>> information_schema without this. Since this is no longer the case I >>>> think it's safe to skip the FirstNormalObjectId check. >>> >>> Wouldn't that mean that FOR ALL TABLES replicates the tables from >>> information_schema? >>> >> >> Yes, as they are not catalog tables, I thought that was your point. > > But we shouldn't do that. So we need to exclude information_schema from > "all tables" somehow. Just probably not by OID, since that is not fixed. >
I am not quite sure I agree with this. Either it's system object and we don't replicate it (which I would have considered to be anything with Oid < FirstNormalObjectId) or it's user made and then it should be replicated. Filtering by schema name is IMHO way too fragile (what stops user creating additional tables there for example). -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
