On 10/01/17 15:06, Peter Eisentraut wrote: > On 1/3/17 5:23 PM, Petr Jelinek wrote: >> I got this remark about IsCatalogClass() from Andres offline as well, >> but it's not true, it only checks for FirstNormalObjectId for objects in >> pg_catalog and toast schemas, not anywhere else. > > I see your statement is correct, but I'm not sure the overall behavior > is sensible. Either we consider the information_schema tables to be > catalog tables, and then IsCatalogClass() should be changed, or we > consider then non-catalog tables, and then we should let them be in > publications. I don't think having a third category of > sometimes-catalog tables is desirable. > > Currently, they clearly behave like non-catalog tables, since you can > just drop and recreate them freely, so I would choose the second option. > It might be worth changing that, but it doesn't have to be the job of > this patch set. >
Okay, looking into my notes, I originally did this because we did not allow adding tables without pkeys to publications which effectively prohibited FOR ALL TABLES publication from working because of information_schema without this. Since this is no longer the case I think it's safe to skip the FirstNormalObjectId check. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
