On Sat, Dec 3, 2016 at 9:02 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Fri, Dec 2, 2016 at 2:56 PM, Robert Haas <robertmh...@gmail.com> wrote: >> On Fri, Dec 2, 2016 at 1:21 PM, Robert Haas <robertmh...@gmail.com> wrote: >>> On Thu, Dec 1, 2016 at 6:33 AM, Thomas Munro >>> <thomas.mu...@enterprisedb.com> wrote: >>>> Please find attached dsa-v8.patch, and also a small test module for >>>> running random allocate/free exercises and dumping the internal >>>> allocator state. >>> >>> OK, I've committed the main patch. >> >> ...but the buildfarm isn't very happy about it. >> >> tern complains: >> >> In file included from dsa.c:58:0: >> ../../../../src/include/utils/dsa.h:59:1: error: unknown type name >> 'pg_atomic_uint64' >> typedef pg_atomic_uint64 dsa_pointer_atomic; >> >> ...but that code is only compiled if #if DSA_POINTER_SIZEOF == 4 fails >> to be true. And that should always be true unless >> PG_HAVE_ATOMIC_U64_SUPPORT is defined. So apparently tern claims to >> PG_HAVE_ATOMIC_U64_SUPPORT but doesn't actually define >> pg_atomic_uint64? That doesn't seem right. > > No, that's not the problem. Just a garden variety thinko in dsa.h. > Will push a fix presently.
Here's a patch to provide the right format string for dsa_pointer to printf-like functions, which clears a warning coming from dsa_dump (a debugging function) on 32 bit systems. -- Thomas Munro http://www.enterprisedb.com
fix-dsa-pointer-format.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
