Andrew Borodin <boro...@octonica.com> writes: >> I don't think there is any reason for this new code to assume NBASE=10000
> There is a comment on line 64 stating that value 10000 is hardcoded > somewhere else, any other value is not recommended and a bunch of code > is left for historical reasons. Doesn't matter: please use NBASE when you mean NBASE. 10000 is just a magic number, and therefore bad coding style. For that matter, spelling INT_MAX as 0x7FFFFFF is also not per project style. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers