Hi, > On 17 Mar 2016, at 09:34, Craig Ringer <cr...@2ndquadrant.com> wrote: > > OK, here's the latest failover slots patch, rebased on top of today's master > plus, in order: > > - Dirty replication slots when confirm_lsn is changed > > (http://www.postgresql.org/message-id/camsr+yhj0oycug2zbyqprhxmcjnkt9d57msxdzgwbkcvx3+...@mail.gmail.com > > <http://www.postgresql.org/message-id/camsr+yhj0oycug2zbyqprhxmcjnkt9d57msxdzgwbkcvx3+...@mail.gmail.com>) > > - logical decoding timeline following > > (http://www.postgresql.org/message-id/CAMsr+YH-C1-X_+s=2nzapnr0wwqja-rumvhsyyzansn93mu...@mail.gmail.com > > <http://www.postgresql.org/message-id/CAMsr+YH-C1-X_+s=2nzapnr0wwqja-rumvhsyyzansn93mu...@mail.gmail.com>) > > The full tree is at > https://github.com/2ndQuadrant/postgres/tree/dev/failover-slots > <https://github.com/2ndQuadrant/postgres/tree/dev/failover-slots> if you want > to avoid the fiddling around required to apply the patch series. > > > <0001-Allow-replication-slots-to-follow-failover.patch><0002-Update-decoding_failover-tests-for-failover-slots.patch><0003-Retain-extra-WAL-for-failover-slots-in-base-backups.patch><0004-Add-the-UI-and-for-failover-slots.patch><0005-Document-failover-slots.patch><0006-Add-failover-to-pg_replication_slots.patch><0007-Introduce-TAP-recovery-tests-for-failover-slots.patch>
Thank you for the update. I’ve got some rejects when applying the 0001-Allow-replication-slots-to-follow-failover.patch after the "Dirty replication slots when confirm_lsn is changed” changes. I think it should be rebased against the master, (might be the consequence of the "logical slots follow the timeline” patch committed). patch -p1 <~/git/pg/patches/failover-slots/v6/0001-Allow-replication-slots-to-follow-failover.patch patching file src/backend/access/rmgrdesc/Makefile Hunk #1 FAILED at 10. 1 out of 1 hunk FAILED -- saving rejects to file src/backend/access/rmgrdesc/Makefile.rej patching file src/backend/access/rmgrdesc/replslotdesc.c patching file src/backend/access/transam/rmgr.c Hunk #1 succeeded at 25 (offset 1 line). patching file src/backend/access/transam/xlog.c Hunk #1 succeeded at 6351 (offset 3 lines). Hunk #2 succeeded at 8199 (offset 14 lines). Hunk #3 succeeded at 8645 (offset 14 lines). Hunk #4 succeeded at 8718 (offset 14 lines). patching file src/backend/commands/dbcommands.c patching file src/backend/replication/basebackup.c patching file src/backend/replication/logical/decode.c Hunk #1 FAILED at 143. 1 out of 1 hunk FAILED -- saving rejects to file src/backend/replication/logical/decode.c.rej patching file src/backend/replication/logical/logical.c patching file src/backend/replication/slot.c patching file src/backend/replication/slotfuncs.c patching file src/backend/replication/walsender.c patching file src/bin/pg_xlogdump/replslotdesc.c patching file src/bin/pg_xlogdump/rmgrdesc.c Hunk #1 succeeded at 27 (offset 1 line). patching file src/include/access/rmgrlist.h Hunk #1 FAILED at 45. 1 out of 1 hunk FAILED -- saving rejects to file src/include/access/rmgrlist.h.rej patching file src/include/replication/slot.h patching file src/include/replication/slot_xlog.h can't find file to patch at input line 1469 Perhaps you used the wrong -p or --strip option? -- Oleksii
