On Wed, Mar 23, 2016 at 12:24 AM, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > Seems reasonable. For the last hunk in your patch, though, I would add > a /* translator: */ comment explaining what each of the values is; > otherwise it's just incomprehensible percent-sign-salad for the poor > translator. Note that if the line is too long you have to use dirty > tricks to avoid pgindent from messing it up (see 673b52753489 for > example)
OK, done this way. > I'm not sure if we should keep "blk" in the original or make it a > complete word. OK, a complete word makes more sense. -- Michael
pg-rewind-debug-fix-v2.patch
Description: binary/octet-stream
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
