On Fri, Mar 18, 2016 at 7:46 PM, Shulgin, Oleksandr <oleksandr.shul...@zalando.de> wrote: > On Fri, Mar 18, 2016 at 7:53 AM, Haribabu Kommi <kommi.harib...@gmail.com> > wrote: >> >> On Thu, Mar 17, 2016 at 6:56 PM, Shulgin, Oleksandr >> <oleksandr.shul...@zalando.de> wrote: >> > >> > You mean change context name and correct the comment? I didn't suggest >> > to >> > change the function name. >> >> Changed the context name and the comment only. > > Check. > > +} lookup_hba_line_context; > ^^^^^ but why TAB here?
corrected. I am not sure why pg_indent is adding a tab here. >> >> > Still remains an issue of representing special keywords in database >> >> > and >> >> > user_name fields, but there was no consensus about that though. >> >> >> >> How about adding keyword_database and keyword_user columns to listing >> >> out the keywords. These columns will be populated only when the hba >> >> line >> >> contains any keywords. >> > >> > >> > Hm... that could work too. >> >> Here I attached patch with the added two keyword columns. > > + if (!tok->quoted && strcmp(tok->string, "all") == 0) > > token_is_keyword(tok, "all") ? updated. >> During the testing with different IP comparison methods like 'samehost' or >> 'samenet', the address details are not displayed. Is there any need of >> showing the IP compare method also? > > Do you mean return "samehost/samenet/all" in the yet another keyword_address > out parameter or something like that? Yes, Currently other than IP/hostname, if the user specifies samehost/samenet/all keywords, currently these are not displayed. I feel adding another column of keyword_address is worth. Updated patch is attached. Regards, Hari Babu Fujitsu Australia
pg-hba-lookup-21-03-2016.patch
Description: Binary data
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
