On Sun, Nov 15, 2015 at 9:25 PM, Etsuro Fujita <fujita.ets...@lab.ntt.co.jp> wrote: > Oops, I've found another one. I think we should update a comment in > postgresGetForeignPlan, too; add remote filtering expressions to the list of > information needed to create a ForeignScan node.
Instead of saying "remote/local", how about saying "remote and local" or just leaving it out altogether as in the attached? -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/postgres_fdw.c index cd4ed0c..a6ba672 100644 --- a/contrib/postgres_fdw/postgres_fdw.c +++ b/contrib/postgres_fdw/postgres_fdw.c @@ -902,8 +902,8 @@ postgresGetForeignPlan(PlannerInfo *root, retrieved_attrs); /* - * Create the ForeignScan node from target list, local filtering - * expressions, remote parameter expressions, and FDW private information. + * Create the ForeignScan node from target list, filtering expressions, + * remote parameter expressions, and FDW private information. * * Note that the remote parameter expressions are stored in the fdw_exprs * field of the finished plan node; we can't keep them in private state
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
