On 2015/11/12 19:02, Etsuro Fujita wrote:
On 2015/11/10 3:53, Robert Haas wrote:
On Mon, Nov 9, 2015 at 5:34 AM, Etsuro Fujita
<fujita.ets...@lab.ntt.co.jp> wrote:
Here is a small patch to update an comment in create_foreignscan_plan;
add fdw_recheck_quals to the list of expressions that need the
replace_nestloop_params processing. I should have updated the comment
when I proposed the patch for the fdw_recheck_quals.
OK, not a big deal, but thanks. Committed.
Thanks!
Oops, I've found another one. I think we should update a comment in
postgresGetForeignPlan, too; add remote filtering expressions to the
list of information needed to create a ForeignScan node.
Best regards,
Etsuro Fujita
*** a/contrib/postgres_fdw/postgres_fdw.c
--- b/contrib/postgres_fdw/postgres_fdw.c
***************
*** 902,908 **** postgresGetForeignPlan(PlannerInfo *root,
retrieved_attrs);
/*
! * Create the ForeignScan node from target list, local filtering
* expressions, remote parameter expressions, and FDW private information.
*
* Note that the remote parameter expressions are stored in the fdw_exprs
--- 902,908 ----
retrieved_attrs);
/*
! * Create the ForeignScan node from target list, remote/local filtering
* expressions, remote parameter expressions, and FDW private information.
*
* Note that the remote parameter expressions are stored in the fdw_exprs
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
