On 10/10/2015 04:32 PM, Michael Paquier wrote: > On Sat, Oct 10, 2015 at 9:04 PM, Amir Rohan wrote: >> Now that v9 fixes the problem, here's a summary from going over the >> entire thread one last time: > > Thanks a lot for the summary of the events. > >> # Windows and TAP sets >> Noah (2015-03) mentioned TAP doesn't work on windows, and hoped >> this would include some work on that. >> IIUC, the facilities and tests do run on windows, but focus was there >> and not the preexisting TAP suite. > > They do work on Windows, see 13d856e. >
Thanks, I did not know that. >> # Test coverage (in the future) >> Andres wanted a test for xid/multixid wraparound which also raises >> the question of the tests that will need to be written in the future. > > I recall that this would have needed extra functions on the backend... > >> The patch focuses on providing facilities, while providing new coverage >> for several features. There should be a TODO list on the wiki (bug >> tracker, actually), where the list of tests to be written can be managed. >> Some were mentioned in the thread (multi/xid wraparound >> hot_standby_feedback, max_standby_archive_delay and >> max_standby_streaming_delay? recovery_target_action? some in your >> original list?), but threads >> are precisely where these things get lost in the cracks. > > Sure, that's an on-going task. > >> # Directory structure >> I suggested keeping backup/log/PGDATA per instance, rejected. > > I guess that I am still flexible on this one, the node information > (own PGDATA, connection string, port, etc.) is logged as well so this > is not a big deal to me... > >> # Parallel tests and port collisions >> Lots about this. Final result is no port races are possible because >> dedicated dirs are used per test, per instance. And because tcp >> isn't used for connections on any platform (can you confirm that's >> true on windows as well? I'm not familiar with sspi and what OSI >> layer it lives on) > > On Windows you remain with the problem that all nodes initialized > using TestLib.pm will listen to 127.0.0.1, sspi being used to ensure > that the connection at user level is secure (additional entries in > pg_hba.conf are added). > >> # decouple cleanup from node shutdown >> Added (in latest patches?) > > Yes this was added. > >> Michael, is there anything else to do here or shall I mark this for >> committer review? > > I have nothing else. Thanks a lot! > Ok, marked for committer, I hope I'm following "correct" cf procedure. Regards, Amir -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
