On 2015-08-05 10:23:31 -0400, Tom Lane wrote: > Andres Freund <and...@anarazel.de> writes: > > How about moving that error check into into the aix template file and > > erroring out there? Since this is master I think it's perfectly fine to > > refuse to work with the buggy unsupported 32 bit compiler. The argument > > not to do so was that PG previously worked in the back branches > > depending on the minor version, but that's not an argument on master. > > The check as Noah wrote it rejects *all* 32-bit IBM compilers, not just > buggy ones. That was okay when the effect was only a rather minor > performance loss, but refusing to build at all would raise the stakes > quite a lot. Unless you are volunteering to find out how to tell broken > compilers from fixed ones more accurately, I think you need to confine > the effects of the check to disabling inlining.
Wasn't the point that 32 bit AIX as a whole hasn't been supported for a couple years now? My willingness to expend effort for that is rather limited. I mean I'd otherwise ok with a PG_FORCE_DISABLE_INLINE flag that takes effect in c.h or so. That could easily be set in src/template/aix. Might also be useful for investigatory purposes every couple years or so. Andres -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
