On Wed, Jun 17, 2015 at 4:57 PM, Vladimir Borodin <r...@simply.name> wrote: > > 17 июня 2015 г., в 9:48, Michael Paquier <michael.paqu...@gmail.com> > написал(а): > > On Wed, Jun 17, 2015 at 3:17 PM, Michael Paquier > <michael.paqu...@gmail.com> wrote: > > As pointed by dev1ant on the original bug report, process_remote_file > should ignore files named as pg_xlog/xlogtemp.*, and I think that this > is the right thing to do. Any objections for a patch that at the same > time makes "xlogtemp." a define declaration in xlog_internal.h? > > > Declaration seems to be the right thing. > > Another problem I’ve caught twice already in the same test: > > error reading xlog record: record with zero length at 0/78000090 > unexpected result while fetching remote files: ERROR: could not open file > "base/13003/t6_2424967" for reading: No such file or directory > The servers diverged at WAL position 0/76BADD50 on timeline 303. > Rewinding from Last common checkpoint at 0/7651F870 on timeline 303 > > I don’t know if this problem could be solved the same way (by skipping such > files)… Should I start a new thread for that?
That's the file of the temporary table, so there is no need to copy it from the source server. pg_rewind can safely skip such file, I think. But even if we make pg_rewind skip such file, we would still get the similar problem. You can see the problem that I reported in other thread. In order to address this type of problem completely, we would need to apply the fix that is been discussed in that thread. http://www.postgresql.org/message-id/CAHGQGwEdsNgeNZo+GyrzZtjW_TkC=XC6XxrjuAZ7=x_cj1a...@mail.gmail.com BTW, even pg_basebackup doesn't skip the file of temporary table. But maybe we should change this, too. Also pg_rewind doesn't skip the files that pg_basebackup does. ISTM that basically pg_rewind can safely skip any files that pg_basebackup does. So probably we need to reconsider which file to make pg_rewind skip. Regards, -- Fujii Masao -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
