On Tue, Feb 17, 2015 at 6:34 AM, Peter Eisentraut <pete...@gmx.net> wrote: >> This patch been reviewed by 4 people, resulting in 2 minor suggestions >> for changes (adding an m modifier, and removing a bogus last). >> >> It has 2 clear upvotes and 0 downvotes. >> >> I think it should be revised along the lines suggested and committed >> without further ado. > > My patch actually only covered the first of the two faulty locations I > pointed out. Attached is a patch that also fixes the second one. I > noticed that DetermineVisualStudioVersion() is never called with an > argument, so I removed that branch altogether.
+1 for those simplifications. And FWIW, it passed my series of tests with MSVC 2010. -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
