On 2014-11-04 17:29:04 +0900, Michael Paquier wrote: > On Tue, Nov 4, 2014 at 5:23 PM, Andres Freund <and...@2ndquadrant.com> > wrote: > > > On 2014-11-04 17:19:18 +0900, Michael Paquier wrote: > > > 5) Reading the code, TransactionTreeSetCommitTimestamp is always called > > > with do_xlog = false, making that actually no timestamps are WAL'd... > > Hence > > > WriteSetTimestampXlogRec is just dead code with the latest version of the > > > patch. IMO, this should be always WAL-logged when track_commit_timestamp > > is > > > on. > > > > It's callable via a 'extern' function. So, I'd not consider it dead. And > > the WAL logging is provided by xact.c's own WAL logging - it always does > > the corresponding committs calls. > > > The code path is unused.
No. It is not. It can be called by extensions? > We'd better make the XLOG record mandatory if > tracking is enabled, as this information is useful on standbys as well. Did you read what I wrote? To quote "And the WAL logging is provided by xact.c's own WAL logging - it always does the corresponding committs calls.". Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
