> Alvaro Herrera <alvhe...@2ndquadrant.com> writes: > > I haven't followed this at all, but I just skimmed over it and noticed > > the CustomPlanMarkPos thingy; apologies if this has been discussed > > before. It seems a bit odd to me; why isn't it sufficient to have a > > boolean flag in regular CustomPlan to indicate that it supports > > mark/restore? > > Yeah, I thought that was pretty bogus too, but it's well down the list of > issues that were there last time I looked at this ... > IIRC, CustomPlanMarkPos was suggested to keep the interface of ExecSupportsMarkRestore() that takes plannode tag to determine whether it support Mark/Restore. As my original proposition did, it seems to me a flag field in CustomPlan structure is straightforward, if we don't hesitate to change ExecSupportsMarkRestore().
Thanks, -- NEC OSS Promotion Center / PG-Strom Project KaiGai Kohei <kai...@ak.jp.nec.com> -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
