Kaigai-san, 2014-07-14 22:18 GMT+09:00 Kohei KaiGai <kai...@kaigai.gr.jp>: > Hanada-san, > > Thanks for your checking. The attached v4 patch is rebased one on the > latest master branch. Indeed, merge conflict was trivial. > > Updates from the v3 are below: > - custom-plan.sgml was renamed to custom-plan-provider.sgml > - fix up the comments in pg_custom_plan_provider.h that mentioned > about old field name. > - applied your patch to fix up typos. (thanks so much!) > - put "costs off" on the EXPLAIN command in the regression test of > ctidscan extension.
Checked, but the patch fails sanity-check test, you need to modify expected file of the test. > Nothing to comment on the design and implementation from your > viewpoint any more? As much as I can tell, the design seems reasonable. After fix for the small issue above, I'll move the patch status to "Ready for committer". -- Shigeru HANADA -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
