On Sat, May 10, 2014 at 9:45 PM, Fabrízio de Royes Mello <fabriziome...@gmail.com> wrote: > Last night I sent a patch [1] to add more tests and change the operator > name. Maybe we can merge the test cases... ;-) Sure, I noticed that. But I think that they are more complicated than necessary. I am as well doubtful about adding test cases with EXPLAIN for a data type test suite.
The patch introduces two new things: pg_lsn_cmp and pg_lsn_hash. To test the former a simple ORDER BY query is enough as cmp is used as an ordering operator. And for the latter creating a hash index looks enough as it tests using the hash function when inserting index tuples. Not to mention as well that the tests are more readable. Regards, -- Michael -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
