Robert Haas <robertmh...@gmail.com> writes: > In other words, let's revert the whole refactoring of this file to > create reg*_guts functions, and instead just copy the relevant logic > for the name lookups into the new functions.
The main discomfort I'd had with this patch was the amount of refactoring it did; that made it hard to verify and I wasn't feeling like it made for much net improvement in cleanliness. If we can do it without that, and have only as much duplicate code as you suggest, then +1. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers