On 2014-01-17 14:18:55 -0500, Tom Lane wrote: > I wrote: > > Meh. This isn't needed if we do what I suggest above, but in any case > > I don't approve of removing the existing [U]INT64_FORMAT macros. > > That breaks code that doesn't need to get broken, probably including > > third-party modules. > > After looking more closely I see you didn't actually *remove* those > macros, just define them in a different place/way. So the above objection > is just noise, sorry. (Though I think it'd be notationally cleaner to let > configure continue to define the macros; it doesn't need to do anything as > ugly as CppAsString2() to concatenate...)
I prefer having configure just define the lenght modifier since that allows to define further macros containing formats. But I think defining them as strings instead row literals as I had might make it a bit less ugly... Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
