Hi, pg_xlogdump cannot properly be built with pgxs since it needs a sourcetree around. That already has confused some users...
How about the attached patch which will tell it's not supported instead of an ominous build error about files that have no rules? Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
>From 856ffaee008486299d9c6db273d05190f461981b Mon Sep 17 00:00:00 2001 From: Andres Freund <and...@anarazel.de> Date: Tue, 27 Aug 2013 16:38:36 +0200 Subject: [PATCH] Remove template support for building pg_xlogdump with pgxs pg_xlogdump could never be built with pgxs since it requires files from the sourcetree, so remove that support. Previously building with pgxs errored out reporting missing rules which isn't helpful. --- contrib/pg_xlogdump/Makefile | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/contrib/pg_xlogdump/Makefile b/contrib/pg_xlogdump/Makefile index 22bd8dc..ada261c 100644 --- a/contrib/pg_xlogdump/Makefile +++ b/contrib/pg_xlogdump/Makefile @@ -13,15 +13,14 @@ RMGRDESCOBJS = $(patsubst %.c,%.o,$(RMGRDESCSOURCES)) EXTRA_CLEAN = $(RMGRDESCSOURCES) xlogreader.c ifdef USE_PGXS -PG_CONFIG = pg_config -PGXS := $(shell $(PG_CONFIG) --pgxs) -include $(PGXS) -else +$(error "pg_xlogdump cannot be built with PGXS") +endif + subdir = contrib/pg_xlogdump top_builddir = ../.. include $(top_builddir)/src/Makefile.global include $(top_srcdir)/contrib/contrib-global.mk -endif + override CPPFLAGS := -DFRONTEND $(CPPFLAGS) -- 1.8.3.251.g1462b67
-- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
