On 2013-07-22 08:53:53 -0400, Tom Lane wrote: > Andres Freund <and...@2ndquadrant.com> writes: > > Would somebody object to making the rmgr's invo value #defines like: > > into enums? > > I think that will create more problems than it fixes. For one thing, > the same field is used to store values that would need to be multiple > independent enum types; and we also store additional bits into that > field.
Oh, I don't want to change the definition of XLogRecord or such. I just want to make the series of #defines an enum so you can write something like inf = record->xl_info & ~XLR_INFO_MASK; switch ((XLogXactRecordType) info) { case ....; } Greetings, Andres Freund -- Andres Freund http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers