On 25.06.2013 20:17, Josh Berkus wrote:
Hackers,
I'd like to take a straw poll here on how we should acknowledge
reviewers. Please answer the below with your thoughts, either on-list
or via private email.
How should reviewers get credited in the release notes?
a) not at all
b) in a single block titled "Reviewers for this version" at the bottom.
c) on the patch they reviewed, for each patch
a)
Sometimes a reviewer contributes greatly to the patch, revising it and
rewriting parts of it. At that point, it's not just a review anymore,
and he/she should be mentioned in the release notes as a co-author.
Should there be a criteria for a "creditable" review?
a) no, all reviews are worthwhile
b) yes, they have to do more than "it compiles"
c) yes, only code reviews should count
This is one reason why I answered a) above. I don't want to set a criteria.
Should reviewers for 9.4 get a "prize", such as a t-shirt, as a
promotion to increase the number of non-submitter reviewers?
a) yes
b) no
c) yes, but submitters and committers should get it too
a).
I don't think we should make any promises, though. Just arbitrarily send
a t-shirt when you feel that someone has done a good job reviewing other
people's patches. And I'm not sure it's really worth the trouble, to
arrange the logistics etc.
- Heikki
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
